Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DAPP-411): changes chain name #38

Merged
merged 14 commits into from
Dec 13, 2023
Merged

feat(DAPP-411): changes chain name #38

merged 14 commits into from
Dec 13, 2023

Conversation

Kelz29
Copy link
Contributor

@Kelz29 Kelz29 commented Nov 21, 2023 •
edited
Loading

Description

changes chain valhalla to testnet

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual Testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@Kelz29 Kelz29 self-assigned this Nov 21, 2023
KalervoHyyppa
KalervoHyyppa suggested changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@KalervoHyyppa KalervoHyyppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

lib/chain/models/chains.dart Outdated Show resolved Hide resolved
lib/chain/models/chains.dart Show resolved Hide resolved
KalervoHyyppa
KalervoHyyppa approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@KalervoHyyppa KalervoHyyppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kelz29 Kelz29 merged commit 2b92aef into dev Dec 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KalervoHyyppa KalervoHyyppa KalervoHyyppa approved these changes

@lukorito lukorito Awaiting requested review from lukorito

Assignees

@Kelz29 Kelz29

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kelz29 @KalervoHyyppa